fix(Bun.serve) fix buffering edge case #5152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @cirospaciari 5 files with test failures on bun-darwin-aarch64:
|
|
✅ test failures on linux-x64-baseline have been resolved. |
|
✅ test failures on linux-x64 have been resolved. |
|
❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:
|
|
bun-server tests are failing |
cirospaciari
commented
Sep 13, 2023
| @@ -1673,7 +1673,7 @@ pub const VirtualMachine = struct { | |||
| printed, | |||
| ), | |||
| }; | |||
| res.* = ErrorableString.err(error.NameTooLong, ResolveMessage.create(global, VirtualMachine.get().allocator, msg, source.utf8()).asVoid()); | |||
| res.* = ErrorableString.err(error.NameTooLong, ResolveMessage.create(global, VirtualMachine.get().allocator, msg, source_utf8.slice()).asVoid()); | |||
There was a problem hiding this comment.
this also solves an issue on linux when running test/js/bun/resolve/resolve.test.ts. I am not sure if this is the right approach
paperdave
pushed a commit
to SuperAuguste/bun
that referenced
this pull request
Sep 18, 2023
* fix buffering clean * fix resolveMaybeNeedsTrailingSlash and try to fix ci/cd error * fix resolveMaybeNeedsTrailingSlash and try to fix ci/cd error * oops --------- Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix: #4966
How did you verify your code works?
I wrote automated tests