fix(spawn) add Uint8Array support for stdout #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
changed the title
cirospaciari
changed the title
| gcTick(); | ||
| }); | ||
|
|
||
| it("Uint8Array works as stdout when is smaller than output", () => { |
There was a problem hiding this comment.
what happens when the output is (1) larger or (2) exactly sized? those cases need tests
There was a problem hiding this comment.
here smaller, larger, or exactly sized 64d536f
|
❌ @cirospaciari 24 files with test failures on linux-x64-baseline:
|
|
❌ @cirospaciari 24 files with test failures on linux-x64:
|
|
❌ @cirospaciari 25 files with test failures on bun-darwin-x64-baseline:
|
cirospaciari
force-pushed
the
ciro/patch-1500
branch
from
64d536f
to
3380f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1500