Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for ws.close #2844

Merged
merged 2 commits into from
May 11, 2023
Merged

add tests for ws.close #2844

merged 2 commits into from
May 11, 2023

Conversation

cirospaciari
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023 •
edited
Loading

❌ @cirospaciari 25 files with test failures on linux-x64-baseline:

  • test/bundler/bundler_browser.test.ts
  • test/bundler/bundler_cjs2esm.test.ts
  • test/bundler/bundler_edgecase.test.ts
  • test/bundler/bundler_jsx.test.ts
  • test/bundler/bundler_plugin.test.ts
  • test/bundler/bundler_reloadable.test.ts
  • test/bundler/bundler_string.test.ts
  • test/bundler/esbuild/dce.test.ts
  • test/bundler/esbuild/default.test.ts
  • test/bundler/esbuild/importstar.test.ts
  • test/bundler/esbuild/loader.test.ts
  • test/bundler/esbuild/splitting.test.ts
  • test/bundler/esbuild/ts.test.ts
  • test/bundler/esbuild/tsconfig.test.ts
  • test/cli/run/preload-test.test.js
  • test/js/bun/http/serve.test.ts
  • test/js/bun/plugin/plugins.test.ts
  • test/js/bun/resolve/png/test-png-import.test.js
  • test/js/bun/test/preload-test.test.js
  • test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
  • test/js/bun/test/snapshot-tests/snapshots/more.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/http/node-http.test.ts
  • test/js/node/readline/readline.node.test.ts
  • test/transpiler/transpiler.test.js

View test output

#1fb3ed254b664857ad1d135fdd91e44894f596ae

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023 •
edited
Loading

❌ @cirospaciari 25 files with test failures on linux-x64:

  • test/bundler/bundler_browser.test.ts
  • test/bundler/bundler_cjs2esm.test.ts
  • test/bundler/bundler_edgecase.test.ts
  • test/bundler/bundler_jsx.test.ts
  • test/bundler/bundler_plugin.test.ts
  • test/bundler/bundler_reloadable.test.ts
  • test/bundler/bundler_string.test.ts
  • test/bundler/esbuild/dce.test.ts
  • test/bundler/esbuild/default.test.ts
  • test/bundler/esbuild/importstar.test.ts
  • test/bundler/esbuild/loader.test.ts
  • test/bundler/esbuild/splitting.test.ts
  • test/bundler/esbuild/ts.test.ts
  • test/bundler/esbuild/tsconfig.test.ts
  • test/cli/run/preload-test.test.js
  • test/js/bun/http/serve.test.ts
  • test/js/bun/plugin/plugins.test.ts
  • test/js/bun/resolve/png/test-png-import.test.js
  • test/js/bun/test/preload-test.test.js
  • test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
  • test/js/bun/test/snapshot-tests/snapshots/more.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/http/node-http.test.ts
  • test/js/node/readline/readline.node.test.ts
  • test/transpiler/transpiler.test.js

View test output

#1fb3ed254b664857ad1d135fdd91e44894f596ae

@Jarred-Sumner
Copy link
Collaborator

now the question is

are the tests on macOS timing out due to a github actions issue or due to the test timing out

@cirospaciari
Copy link
Collaborator Author

now the question is

are the tests on macOS timing out due to a github actions issue or due to the test timing out

I will add a manual timeout on ws.close test, so if is the test, will popup as fail

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023 •
edited
Loading

❌ @cirospaciari 26 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/bundler_browser.test.ts
  • test/bundler/bundler_cjs2esm.test.ts
  • test/bundler/bundler_edgecase.test.ts
  • test/bundler/bundler_jsx.test.ts
  • test/bundler/bundler_plugin.test.ts
  • test/bundler/bundler_reloadable.test.ts
  • test/bundler/bundler_string.test.ts
  • test/bundler/esbuild/dce.test.ts
  • test/bundler/esbuild/default.test.ts
  • test/bundler/esbuild/importstar.test.ts
  • test/bundler/esbuild/loader.test.ts
  • test/bundler/esbuild/splitting.test.ts
  • test/bundler/esbuild/ts.test.ts
  • test/bundler/esbuild/tsconfig.test.ts
  • test/cli/run/preload-test.test.js
  • test/js/bun/http/serve.test.ts
  • test/js/bun/plugin/plugins.test.ts
  • test/js/bun/resolve/png/test-png-import.test.js
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/test/preload-test.test.js
  • test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
  • test/js/bun/test/snapshot-tests/snapshots/more.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/http/node-http.test.ts
  • test/js/node/readline/readline.node.test.ts
  • test/transpiler/transpiler.test.js

View test output

#1fb3ed254b664857ad1d135fdd91e44894f596ae

@Jarred-Sumner Jarred-Sumner merged commit d032b73 into main May 11, 2023
@Jarred-Sumner Jarred-Sumner deleted the ciro/patch-2631-tests branch May 11, 2023 09:30
@Jarred-Sumner
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cirospaciari @Jarred-Sumner