fix(ws) fix closing WS with code and reason #2843

cirospaciari · 2023-05-10T21:36:27Z

Jarred-Sumner · 2023-05-10T21:37:32Z

Thank you

Jarred-Sumner · 2023-05-10T21:37:59Z

Can you add a test

cirospaciari · 2023-05-10T21:38:54Z

Can you add a test

sure

github-actions · 2023-05-10T22:10:50Z

❌ @cirospaciari 25 files with test failures on linux-x64-baseline:

test/bundler/bundler_browser.test.ts
test/bundler/bundler_cjs2esm.test.ts
test/bundler/bundler_edgecase.test.ts
test/bundler/bundler_jsx.test.ts
test/bundler/bundler_plugin.test.ts
test/bundler/bundler_reloadable.test.ts
test/bundler/bundler_string.test.ts
test/bundler/esbuild/dce.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/bundler/esbuild/loader.test.ts
test/bundler/esbuild/splitting.test.ts
test/bundler/esbuild/ts.test.ts
test/bundler/esbuild/tsconfig.test.ts
test/cli/run/preload-test.test.js
test/js/bun/http/serve.test.ts
test/js/bun/plugin/plugins.test.ts
test/js/bun/resolve/png/test-png-import.test.js
test/js/bun/test/preload-test.test.js
test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
test/js/bun/test/snapshot-tests/snapshots/more.test.ts
test/js/node/child_process/child_process-node.test.js
test/js/node/http/node-http.test.ts
test/js/node/readline/readline.node.test.ts
test/transpiler/transpiler.test.js

github-actions · 2023-05-10T22:11:03Z

❌ @cirospaciari 25 files with test failures on linux-x64:

test/bundler/bundler_browser.test.ts
test/bundler/bundler_cjs2esm.test.ts
test/bundler/bundler_edgecase.test.ts
test/bundler/bundler_jsx.test.ts
test/bundler/bundler_plugin.test.ts
test/bundler/bundler_reloadable.test.ts
test/bundler/bundler_string.test.ts
test/bundler/esbuild/dce.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/bundler/esbuild/loader.test.ts
test/bundler/esbuild/splitting.test.ts
test/bundler/esbuild/ts.test.ts
test/bundler/esbuild/tsconfig.test.ts
test/cli/run/preload-test.test.js
test/js/bun/http/serve.test.ts
test/js/bun/plugin/plugins.test.ts
test/js/bun/resolve/png/test-png-import.test.js
test/js/bun/test/preload-test.test.js
test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
test/js/bun/test/snapshot-tests/snapshots/more.test.ts
test/js/node/child_process/child_process-node.test.js
test/js/node/http/node-http.test.ts
test/js/node/readline/readline.node.test.ts
test/transpiler/transpiler.test.js

github-actions · 2023-05-10T22:30:20Z

❌ @cirospaciari 27 files with test failures on bun-darwin-x64-baseline:

test/bundler/bundler_browser.test.ts
test/bundler/bundler_cjs2esm.test.ts
test/bundler/bundler_edgecase.test.ts
test/bundler/bundler_jsx.test.ts
test/bundler/bundler_plugin.test.ts
test/bundler/bundler_reloadable.test.ts
test/bundler/bundler_string.test.ts
test/bundler/esbuild/dce.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/bundler/esbuild/loader.test.ts
test/bundler/esbuild/splitting.test.ts
test/bundler/esbuild/ts.test.ts
test/bundler/esbuild/tsconfig.test.ts
test/cli/run/preload-test.test.js
test/js/bun/http/serve.test.ts
test/js/bun/plugin/plugins.test.ts
test/js/bun/resolve/png/test-png-import.test.js
test/js/bun/sqlite/sqlite.test.js
test/js/bun/test/preload-test.test.js
test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
test/js/bun/test/snapshot-tests/snapshots/more.test.ts
test/js/bun/util/sleepSync.test.ts
test/js/node/child_process/child_process-node.test.js
test/js/node/http/node-http.test.ts
test/js/node/readline/readline.node.test.ts
test/transpiler/transpiler.test.js

fix closing WS with code and reason

fb80572

cirospaciari requested a review from Jarred-Sumner May 10, 2023 21:36

Jarred-Sumner merged commit 643aa27 into main May 10, 2023

Jarred-Sumner deleted the ciro/patch-2631 branch May 10, 2023 21:37

Provide feedback