Implement describe.skip
#2836
Merged
Implement describe.skip
#2836
+177
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackmann
commented
May 10, 2023
| @@ -48,7 +48,7 @@ namespace WebCore { | |||
| const JSC::ConstructAbility s_bundlerPluginRunOnResolvePluginsCodeConstructAbility = JSC::ConstructAbility::CannotConstruct; | |||
| const JSC::ConstructorKind s_bundlerPluginRunOnResolvePluginsCodeConstructorKind = JSC::ConstructorKind::None; | |||
| const JSC::ImplementationVisibility s_bundlerPluginRunOnResolvePluginsCodeImplementationVisibility = JSC::ImplementationVisibility::Public; | |||
| const int s_bundlerPluginRunOnResolvePluginsCodeLength = 3593; | |||
| const int s_bundlerPluginRunOnResolvePluginsCodeLength = 3619; | |||
There was a problem hiding this comment.
This and other changes in this file were auto-generated. I suppose that's expected?
There was a problem hiding this comment.
Yeah this was fixed on main before you rebased last
| }); | ||
| }); | ||
|
|
||
| describe.skip("skip test outer", () => { |
There was a problem hiding this comment.
can you add a test that checks we also skip beforeAll, afterAll, beforeEach, and afterEach (assuming Jest does that too)?
blackmann
commented
May 10, 2023
| @@ -3635,7 +3635,7 @@ pub const DescribeScope = struct { | |||
| this.pending_tests.unset(test_id); | |||
|
|
|||
| if (!skipped) { | |||
| const afterEach = this.execCallback(globalThis, .afterEach); | |||
| const afterEach = this.runCallback(globalThis, .afterEach); | |||
There was a problem hiding this comment.
Incidentally resolves: #2528
|
This looks great. Thank you. There will be some unrelated test failures, don't worry about those. Let's merge after tests run |
Jarred-Sumner
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.