throw returned errors on wrapWithHasContainer

[paperdave]

if a function with wrapWithHasContainer does not get an error reference passed to it, then instead of checking that reference (would be always null), we check the result .isError and then properly throw that.

also refactored to use defer deinit of the iterator instead of how it was copy pasted throughout the function.

this is one of the first few times I've used comptime stuff, but I'm 99% sure i did it correctly. crazy cool stuff.

Fixes #2820 and some similar issues in other functions that use this wrapper

[github-actions]

❌ @paperdave 25 files with test failures on linux-x64:

• test/bundler/bundler_browser.test.ts
• test/bundler/bundler_cjs2esm.test.ts
• test/bundler/bundler_edgecase.test.ts
• test/bundler/bundler_jsx.test.ts
• test/bundler/bundler_plugin.test.ts
• test/bundler/bundler_string.test.ts
• test/bundler/esbuild/dce.test.ts
• test/bundler/esbuild/default.test.ts
• test/bundler/esbuild/importstar.test.ts
• test/bundler/esbuild/loader.test.ts
• test/bundler/esbuild/splitting.test.ts
• test/bundler/esbuild/ts.test.ts
• test/bundler/esbuild/tsconfig.test.ts
• test/cli/run/preload-test.test.js
• test/js/bun/http/serve.test.ts
• test/js/bun/plugin/plugins.test.ts
• test/js/bun/resolve/png/test-png-import.test.js
• test/js/bun/test/preload-test.test.js
• test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
• test/js/bun/test/snapshot-tests/snapshots/more.test.ts
• test/js/bun/test/snapshot-tests/snapshots/snapshot.test.ts
• test/js/node/child_process/child_process-node.test.js
• test/js/node/http/node-http.test.ts
• test/js/node/readline/readline.node.test.ts
• test/transpiler/transpiler.test.js

View test output

^{#8c43bd00c177d0459d6eb439f39e474ccca42c81}

[github-actions]

❌ @paperdave 26 files with test failures on linux-x64-baseline:

• test/bundler/bundler_browser.test.ts
• test/bundler/bundler_cjs2esm.test.ts
• test/bundler/bundler_edgecase.test.ts
• test/bundler/bundler_jsx.test.ts
• test/bundler/bundler_plugin.test.ts
• test/bundler/bundler_string.test.ts
• test/bundler/esbuild/dce.test.ts
• test/bundler/esbuild/default.test.ts
• test/bundler/esbuild/importstar.test.ts
• test/bundler/esbuild/loader.test.ts
• test/bundler/esbuild/splitting.test.ts
• test/bundler/esbuild/ts.test.ts
• test/bundler/esbuild/tsconfig.test.ts
• test/cli/hot/hot.test.ts
• test/cli/run/preload-test.test.js
• test/js/bun/http/serve.test.ts
• test/js/bun/plugin/plugins.test.ts
• test/js/bun/resolve/png/test-png-import.test.js
• test/js/bun/test/preload-test.test.js
• test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
• test/js/bun/test/snapshot-tests/snapshots/more.test.ts
• test/js/bun/test/snapshot-tests/snapshots/snapshot.test.ts
• test/js/node/child_process/child_process-node.test.js
• test/js/node/http/node-http.test.ts
• test/js/node/readline/readline.node.test.ts
• test/transpiler/transpiler.test.js

View test output

^{#8c43bd00c177d0459d6eb439f39e474ccca42c81}

[github-actions]

❌ @paperdave 27 files with test failures on bun-darwin-x64-baseline:

• test/bundler/bundler_browser.test.ts
• test/bundler/bundler_cjs2esm.test.ts
• test/bundler/bundler_edgecase.test.ts
• test/bundler/bundler_jsx.test.ts
• test/bundler/bundler_plugin.test.ts
• test/bundler/bundler_string.test.ts
• test/bundler/esbuild/dce.test.ts
• test/bundler/esbuild/default.test.ts
• test/bundler/esbuild/importstar.test.ts
• test/bundler/esbuild/loader.test.ts
• test/bundler/esbuild/splitting.test.ts
• test/bundler/esbuild/ts.test.ts
• test/bundler/esbuild/tsconfig.test.ts
• test/cli/run/preload-test.test.js
• test/js/bun/http/serve.test.ts
• test/js/bun/plugin/plugins.test.ts
• test/js/bun/resolve/png/test-png-import.test.js
• test/js/bun/sqlite/sqlite.test.js
• test/js/bun/test/preload-test.test.js
• test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
• test/js/bun/test/snapshot-tests/snapshots/more.test.ts
• test/js/bun/test/snapshot-tests/snapshots/snapshot.test.ts
• test/js/bun/util/sleepSync.test.ts
• test/js/node/child_process/child_process-node.test.js
• test/js/node/http/node-http.test.ts
• test/js/node/readline/readline.node.test.ts
• test/transpiler/transpiler.test.js

View test output

^{#8c43bd00c177d0459d6eb439f39e474ccca42c81}

[Jarred-Sumner]

Thank you