fix source map line offsets #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sourcemap/sourcemap.zig
Outdated
| @@ -356,17 +356,15 @@ pub const LineColumnOffset = struct { | |||
| std.debug.assert(i >= offset); | |||
| std.debug.assert(i < input.len); | |||
|
|
|||
| offset = i + 1; | |||
| var iter = strings.CodepointIterator.initOffset(input, i); | |||
| var cp = iter.nextCodepoint(); | |||
There was a problem hiding this comment.
you can't use Cursor? We should clean up this code, but it was done this way because there were off-by-one errors when using .next() because the offset was updated after use when usually you want the previous value
There was a problem hiding this comment.
switched back to Cursor. Should we change Cursor.i to a usize?
|
❌ @dylan-conway 24 files with test failures on bun-darwin-x64-baseline:
|
|
❌ @dylan-conway 22 files with test failures on linux-x64-baseline:
|
|
❌ @dylan-conway 22 files with test failures on linux-x64:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.