Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sockets) always safe deinit socket context #2611

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

cirospaciari
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

@cirospaciari 13 files with test failures on linux-x64:

  • test/bundler/esbuild/default.test.ts
  • test/bundler/esbuild/importstar.test.ts
  • test/bundler/esbuild/splitting.test.ts
  • test/bundler/transpiler.test.js
  • test/js/bun/http/serve.test.ts
  • test/js/bun/plugin/plugins.test.ts
  • test/js/bun/resolve/import-meta.test.js
  • test/js/bun/resolve/png/test-png-import.test.js
  • test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
  • test/js/bun/test/snapshot-tests/snapshots/more.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/stubs.test.js

View test output

#d3fabe7b5faf6672d30828a8db9703bc9f608d48

@github-actions
Copy link
Contributor

@cirospaciari 13 files with test failures on linux-x64-baseline:

  • test/bundler/esbuild/default.test.ts
  • test/bundler/esbuild/importstar.test.ts
  • test/bundler/esbuild/splitting.test.ts
  • test/bundler/transpiler.test.js
  • test/js/bun/http/serve.test.ts
  • test/js/bun/plugin/plugins.test.ts
  • test/js/bun/resolve/import-meta.test.js
  • test/js/bun/resolve/png/test-png-import.test.js
  • test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
  • test/js/bun/test/snapshot-tests/snapshots/more.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/stubs.test.js

View test output

#d3fabe7b5faf6672d30828a8db9703bc9f608d48

@github-actions
Copy link
Contributor

@cirospaciari 18 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/esbuild/default.test.ts
  • test/bundler/esbuild/importstar.test.ts
  • test/bundler/esbuild/splitting.test.ts
  • test/bundler/transpiler.test.js
  • test/js/bun/http/bun-server.test.ts
  • test/js/bun/http/serve.test.ts
  • test/js/bun/plugin/plugins.test.ts
  • test/js/bun/resolve/import-meta.test.js
  • test/js/bun/resolve/png/test-png-import.test.js
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/test/snapshot-tests/snapshots/more-snapshots/different-directory.test.ts
  • test/js/bun/test/snapshot-tests/snapshots/more.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/sleepSync.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/child_process/child_process.test.ts
  • test/js/node/stubs.test.js

View test output

#d3fabe7b5faf6672d30828a8db9703bc9f608d48

@Jarred-Sumner Jarred-Sumner merged commit f91dc8c into main Apr 10, 2023
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-context-deinit branch April 10, 2023 22:05
@Jarred-Sumner
Copy link
Collaborator

Thank you

slightly worried about memory leaks

Electroid pushed a commit that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants