Skip to content

Conversation

robobun
Copy link
Collaborator

@robobun robobun commented Oct 6, 2025

Summary

Added missing worker_threads test files to no-validate-leaksan.txt:

  • test/js/node/worker_threads/15787.test.ts
  • test/js/node/worker_threads/worker-async-dispose.test.ts

These tests were missing from the list even though worker_destruction.test.ts was already present.

Test plan

  • CI passes

🤖 Generated with Claude Code

Added the following tests:
- test/js/node/worker_threads/15787.test.ts
- test/js/node/worker_threads/worker-async-dispose.test.ts

These tests are already excluded but were missing from the list.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@robobun
Copy link
Collaborator Author

robobun commented Oct 6, 2025

Updated 6:44 PM PT - Oct 6th, 2025

❌ Your commit c87c2d00 has 3 failures in Build #28217 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 23309

That installs a local version of the PR into your bun-23309 executable, so you can run:

bun-23309 --bun

@github-actions github-actions bot added the claude label Oct 6, 2025
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

The change updates test/no-validate-leaksan.txt by adding two worker_threads test paths (test/js/node/worker_threads/15787.test.ts and test/js/node/worker_threads/worker-async-dispose.test.ts) to the no-leak sanitizer exclusion list. No exported or public API changes.

Changes

Cohort / File(s) Summary
Test exclusion list update
test/no-validate-leaksan.txt
Added test/js/node/worker_threads/15787.test.ts and test/js/node/worker_threads/worker-async-dispose.test.ts to the no-leak sanitizer list.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is structured with "## Summary" and "## Test plan" sections rather than the required "### What does this PR do?" and "### How did you verify your code works?" headings, so it does not align with the repository’s description template. While it conveys the change and a basic test plan, the section titles do not match the expected format and may confuse reviewers. This mismatch flags the description as non-compliant with the template. Please update the description to use the exact template headings by replacing "## Summary" with "### What does this PR do?" and "## Test plan" with "### How did you verify your code works?", and ensure any additional context is placed under those sections to maintain consistency and clarity.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the primary change by specifying that worker_threads tests are being added to no-validate-leaksan.txt, matching the actual modifications in the changeset. It is specific and directly related to the main change without including extraneous details. Therefore, it meets the repository’s guidelines for a descriptive and focused pull request title.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/add-worker-tests-to-no-validate-leaksan

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b22e19b and c87c2d0.

📒 Files selected for processing (1)
  • test/no-validate-leaksan.txt (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
test/**

📄 CodeRabbit inference engine (.cursor/rules/writing-tests.mdc)

Place all tests under the test/ directory

Files:

  • test/no-validate-leaksan.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Format
🔇 Additional comments (1)
test/no-validate-leaksan.txt (1)

63-64: Worker exclusions backfilled correctly.

Thanks for adding the missing worker_threads tests alongside the existing worker_destruction entry—keeps the LeakSanitizer skip list consistent.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant