-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add worker_threads tests to no-validate-leaksan.txt #23309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added the following tests: - test/js/node/worker_threads/15787.test.ts - test/js/node/worker_threads/worker-async-dispose.test.ts These tests are already excluded but were missing from the list. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughThe change updates test/no-validate-leaksan.txt by adding two worker_threads test paths (test/js/node/worker_threads/15787.test.ts and test/js/node/worker_threads/worker-async-dispose.test.ts) to the no-leak sanitizer exclusion list. No exported or public API changes. Changes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)test/**📄 CodeRabbit inference engine (.cursor/rules/writing-tests.mdc)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Comment |
Summary
Added missing worker_threads test files to no-validate-leaksan.txt:
These tests were missing from the list even though worker_destruction.test.ts was already present.
Test plan
🤖 Generated with Claude Code