do not release weak refs twice #19149
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 3:58 PM PT - Apr 22nd, 2025
✅ @DonIsaac, your commit 27b8a3afd473357a9f7191f93fc7a08128fd44ba passed in 🧪 try this PR locally: bunx bun-pr 19149 |
|
edit: no noticeable difference in async and websocket benchmarks. |
DonIsaac
commented
Apr 21, 2025
| @@ -3948,6 +3948,7 @@ void GlobalObject::drainMicrotasks() | |||
| if (auto nextTickQueue = this->m_nextTickQueue.get()) { | |||
| Bun::JSNextTickQueue* queue = jsCast<Bun::JSNextTickQueue*>(nextTickQueue); | |||
| queue->drain(vm, this); | |||
| vm.finalizeSynchronousJSExecution(); | |||
There was a problem hiding this comment.
note: also called by vm.drainMicrotasks()
DonIsaac
changed the title
…release-weakref-twice
…oven-sh/bun into don/experiment/no-release-weakref-twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes several improvements and fixes to microtask-related code
releaseWeakRefsbefore draining microtask queue. It's already done afterwards.JSGlobalObject.reload()now drainsnextTickqueue as well as microtask queuenextTickqueue when there's a pending termination exceptionJSC__JSGlobalObject__drainMicrotaskswill already callfinalizeSynchronousJSExecution, meaning we incrementm_currentWeakRefVersiontwice (once before draining, once after draining).While
finalizeSynchronousJSExecutionis cheap, It is defined in C++ code, making it opaque to the Zig compiler and preventing inlining optimizations. Draining microtasks is a critical perf path, and avoiding this extra function call may lead to perf gains.How did you verify your code works?
let's see what happens in CI