Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bun.$ should keep the Bun process alive while a command is running #11950

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Jun 18, 2024

What does this PR do?

Fixes #12679

The following two scripts exit with exit code 1 but they should exit with exit code 0.

process.exitCode = 1;

(async () => {
  await Bun.$`ls .`;
  process.exit(0);
})();
process.exitCode = 1;

(async () => {
  await Bun.$`${process.execPath} -e "console.log('hi')"`;
  process.exit(0);
})();

How did you verify your code works?

There is a test

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review June 18, 2024 13:04
Copy link
Contributor

github-actions bot commented Jun 18, 2024

@Jarred-Sumner, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/js/web/workers/worker.test.ts 1 failing

💻 1 failing tests Darwin x64 baseline

  • test/js/node/http/node-http.test.ts 1 failing

💻 1 failing tests Darwin x64

  • test/cli/hot/hot.test.ts 1 failing

🪟💻 3 failing tests Windows x64 baseline

  • test/cli/install/registry/bun-install-registry.test.ts 2 failing
  • test/js/bun/shell/shell-keepalive.test.ts 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing

View logs

Copy link
Contributor

@zackradisic zackradisic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun shell can't get output when using mp4dump
2 participants