Rewrite `node:crypto`

[Jarred-Sumner]

There are several open issues about node:crypto

• Poor performance for crypto's privateEncrypt/publicDecrypt #6076
• jwks-rsa and/or express-jwt not working with bun #10511
• Mineflayer error: Cant Authenticate with Microsoft #10049
• Export named 'diffieHellman' not found in module 'crypto' when running in Nuxt server with bun --bun dev #9569
• Import named 'diffieHellman' not found in module 'crypto' #6782
• jose is not working in sveltekit #7560
• node-rsa decrypt 20x slowser then node #4859
• Bun v1.2.2 seems not to support JsonWebToken (jsonwebtoken package) #13682

Our current implementation of node:crypto is an incrementally modified fork of the browserify crypto polyfill with a lot of BoringSSL bindings added in key places.

The browserify crypto polyfill was a great starting point, but we've outgrown it.

When you skim through the code, you'll note that very little of it makes sense in the context of Bun

bun/src/js/node/crypto.ts

Lines 2238 to 2258 in 1bec6c3

	var out = self2._cipher.encryptBlockRaw(self2._prev);
	return incr32(self2._prev), out;
	}
	var blockSize = 16;
	exports.encrypt = function (self2, chunk) {
	var chunkNum = Math.ceil(chunk.length / blockSize),
	start = self2._cache.length;
	self2._cache = Buffer2.concat([self2._cache, Buffer2.allocUnsafe(chunkNum * blockSize)]);
	for (var i = 0; i < chunkNum; i++) {
	var out = getBlock(self2),
	offset = start + i * blockSize;
	self2._cache.writeUInt32BE(out[0], offset + 0),
	self2._cache.writeUInt32BE(out[1], offset + 4),
	self2._cache.writeUInt32BE(out[2], offset + 8),
	self2._cache.writeUInt32BE(out[3], offset + 12);
	}
	var pad = self2._cache.slice(0, chunk.length);
	return (self2._cache = self2._cache.slice(chunk.length)), xor(chunk, pad);
	};
	},
	});

It has a JavaScript implementation of MD5, SHA1, crypto.randomBytes, DES, AES, diffieHelman, etc. We have BoringSSL. We even expose BoringSSL's MD5, SHA1, etc. Let's use it.

Let's also get rid of the commonJS wrappers in it. The only JavaScript code in node:crypto should be related to streams, or wrapping a native implementation in a stream. Everything else should be in native code.

The other issue here is in the particular stream implementations themselves. There are likely many small subtly incompatible bugs in the various classes exposed by node:crypto. We need to be running node's tests against our crypto implementation. Ideally, we'd be running other test suites too for this.

[wpaulino]

I plan to start with the switch to BoringSSL for publicEncrypt/privateDecrypt.

[jlucaso1]

I need help to complete the feature to implement X25519. I have copied files from safari webkit implementation, but with no success
#13798

[TechFun4]

wow i learned this the hard way lol