Skip to content

Commit

Permalink
Fix broken test suite (plaid#68)
Browse files Browse the repository at this point in the history
*  gitignore: add .cache directory

* travis: remove pre-release python 3.5 versions

* travis: use the project make script

* requirements: bump pytest reqs for py3.5 compat

The 3.x branch of pytest drops support for <3.3 which, according, to the travis file, this project still supports. As a consequence of that, we can only go up to pytest 2.9.2.

* setup.py: add python 3.5 trove classifier

This project is tested in that environment.

* client tests: correct ResourceNotFound testing

test_ResourceNotFound_connect was checking for a ResourceNotFoundError on an operation that should actually succeed. This modifies that operation so that it will fail as expected.
  • Loading branch information
thomasw authored and zallarak committed Jan 13, 2017
1 parent 78ea31e commit 4d6508f
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 12 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ pip-log.txt
# Unit test / coverage reports
.coverage
.tox
.cache
nosetests.xml

# Translations
Expand Down
15 changes: 6 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,10 @@ python:
- "3.2"
- "3.3"
- "3.4"
- "3.5.0b3"
- "3.5-dev"
- "nightly"

- "3.5"
install:
- "pip install -r requirements.txt"
- "pip install flake8"

becore_script: "flake8 plaid tests"
script: nosetests
- "make setup"
becore_script:
- "make lint"
script:
- "make test"
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ cov-core==1.7
coverage==3.7.1
flake8==2.4.1
mock==1.0.1
py==1.4.20
pytest==2.5.2
py==1.4.32
pytest==2.9.2
pytest-cov==1.6
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Topic :: Software Development :: Libraries :: Python Modules",
"Environment :: Web Environment",
]
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def test_unauthorizedError_bad_password():
def test_ResourceNotFound_connect():
client = Client('test_id', 'test_secret')
with pytest.raises(ResourceNotFoundError):
client.connect('pnc', no_mfa_credentials)
client.connect('notpnc', no_mfa_credentials)


def test_ResourceNotFound_categories():
Expand Down

0 comments on commit 4d6508f

Please sign in to comment.