Easy configuration of global NetworkSession timeouts & more URLSessionConfiguration convenience
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sionConfiguration` convenience Fixes #1 ### NetworkRequestFactory configuratoin `NetworkRequestSession.init` now accepts an `eventSession` parameter that is used solely when creating requests for `EventSource` & `EventPublusher` instances.. The parameter defaults to `nil` in which case it is coped from the standard `session` parameter. When copying the regular session it uses the new `URLSessionConfiguration.events()` convenience factory (see below). ### URLSessionConfiguration for “events” Since Server-Sent Event requests have special requirements (e.g. long timeouts) a convenience extension factory method `events()` has been added. It creates a configuration sutiable for SSE streams. ### Global defaults All of the defaults used by the `URLSessionConfiguration` extension factoires (both `rest()` and `events()`) now have configurable default values for easy global configuration.
kdubb
force-pushed
the
feature/network_config
branch
from
1370e98 to
22d0950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
NetworkRequestFactory configuratoin
NetworkRequestSession.initnow accepts aneventSessionparameter that is used solely when creating requests forEventSource&EventPublusherinstances.. The parameter defaults tonilin which case it is coped from the standardsessionparameter. When copying the regular session it uses the newURLSessionConfiguration.events()convenience factory (see below).URLSessionConfiguration for “events”
Since Server-Sent Event requests have special requirements (e.g. long timeouts) a convenience extension factory method
events()has been added. It creates a configuration sutiable for SSE streams.Global defaults
All of the defaults used by the
URLSessionConfigurationextension factoires (bothrest()andevents()) now have configurable default values for easy global configuration.