fix(cli): use flavor-aware content loading for text formatter snippets #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
The text formatter was loading llms.txt content without considering which flavor (txt vs full) the search hit came from. This caused line number mismatches and incorrect snippets when searching against llms-full.txt. Changes: - Modified cache key to include flavor: alias:flavor format - Updated load_llms_lines() to accept flavor parameter - Use storage.flavor_file_path() instead of llms_txt_path() - Extract flavor from SearchHit.flavor field with txt fallback Now snippets correctly display content from the same flavor file that was searched, fixing the issue where all text results showed identical/incorrect snippets. Test coverage: - Added text_formatter_uses_correct_flavor_for_snippets() integration test - Verifies text output contains snippets from searched flavor, not wrong flavor - Tests both directions: full→full and txt→txt Fixes #232
galligan
force-pushed
the
gt/fix-text-formatter-flavor-mismatch
branch
from
8ec98e9 to
c1a02b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text formatter was loading llms.txt content without considering which
flavor (txt vs full) the search hit came from. This caused line number
mismatches and incorrect snippets when searching against llms-full.txt.
Changes:
Now snippets correctly display content from the same flavor file that was
searched, fixing the issue where all text results showed identical/incorrect
snippets.
Fixes #232