Add db_instance_type and db_engine_version to main variables #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| variable "db_instance_type" { | ||
| type = string | ||
| description = "RDS instance type to launch for PostgresQL database." | ||
| default = "db.t2.small" |
There was a problem hiding this comment.
I suggest to change it to db.t3.small like in #72
|
@oavdeev Do you have time to take a look at this please? |
oavdeev
approved these changes
Sep 1, 2023
Member
|
Sorry it took so long, we'll merge & test & cut a new release in the next few days |
|
@oavdeev Have you had a chance to look at this? This change would be very helpful for us too. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to change
db_instance_typeanddb_engine_versionfrom the main metaflow terraform module.Testing Screenshots
RDS micro instance with engine version 14