Allow to change UI image in high level module #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 That looks reasonable to me, I think we can merge this once the pre-commit failure is fixed |
Contributor
Author
|
Didn't notice the docs were automatically generated, fixed. Would also be cool to bump the default ui version to 1.1.2 as it is supported with the service version 2.2.2 according to the releases and also includes the very useful cards feature :) |
oavdeev
approved these changes
Apr 21, 2022
Limess
pushed a commit
to signal-ai/terraform-aws-metaflow
that referenced
this pull request
May 26, 2022
* Allow to change UI image in high level module * Update readme to include ui docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR allows users to specify the UI docker image from the high level module, as it is currently done for the metadata service docker image.
Cheers.