Skip to content

Adding Apache2 License #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Adding Apache2 License #8

wants to merge 10 commits into from

Conversation

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Apr 28, 2020

Replaces openark#7 (cc @MarkAtwood)

golib was originally developed at Outbrain. The original repo lacks LICENSE and I'm not sure if it's maintained (I created it at the time). At Outbrain, what code I released was under Apache2.
I'm creating this PR against both openark/golib and outbrain/golib

Shlomi Noach and others added 10 commits May 17, 2016 15:43
assuming this project under openark
6288fd1
assuming this project under openark
9d3195d
removed eclipse project file
e1304e0
rearranged tree
4a5b6d4
@sjmudd
queryResultData: do not log twice, just return the error to caller
ea13fb9 
Step 1 to fix stuff like the following seen in orchestrator logging:

2018-11-24T19:24:04.026091+01:00 orchestratorapp orchestrator[59561]: Error 1146: Table 'mydb.pseudo_gtid_status' doesn't exist
2018-11-24T19:24:04.027256+01:00 orchestratorapp orchestrator[59561]: 2018-11-24 19:24:04 ERROR Error 1146: Table 'mydb.pseudo_gtid_status' doesn't exist
2018-11-24T19:24:04.027352+01:00 orchestratorapp orchestrator[59561]: 2018-11-24 19:24:04 ERROR ReadTopologyInstance(somehost:3306:3306) DetectPseudoGTIDQuery: Error 1146: Table 'mydb.pseudo_gtid_status' doesn't exist

This needs to be logged once and not in 3 places.
This specific patch fixes the issue of the most downstream call being
logged when the error is being passed (and used) by the caller.
Merge pull request #3 from sjmudd/do_not_log_twice
ae63dcc 
queryResultData: do not log twice, just return the error to caller
Add TZ support
0e4a2c5
Simplify
2ee5d8b
Merge pull request #4 from jfudally/jfudally-timezone-support
8fd0aff 
Add TZ support
@shlomi-noach
adding Apache2 license
06f54c7
@shlomi-noach shlomi-noach mentioned this pull request Apr 28, 2020
Open
@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Apr 28, 2020

Sorry, I forgot to point out that https://github.com/outbrain/golib is an extract from https://github.com/outbrain/orchestrator, released as Apache 2, hence the license for #8 is derivatively Apache 2.

@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Apr 30, 2020 •
edited
Loading

While I still hold ownership for this repo, I'm happy if someone in Outbrain can review.

@shlomi-noach shlomi-noach requested a review from yonatanm May 3, 2020 08:09
@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented May 3, 2020

So, at this time, some of the commits in the PR came from downstream https://github.com/openark/golib, a fork of this repository.

One of the most annoying things about golang is that code location (URL) is embedded in code. While this repo is on github.com/outbrain/golib, the fork has to use github.com/openark/golib. Now that some code has been pushed upstream, there's conflict between code and location.

Let me open a new PR just for licensing purposes, that does not include all these code changes.

@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented May 3, 2020

Please see #9 for a license-only change; code changes are irrelevant for now.

@shlomi-noach shlomi-noach mentioned this pull request May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonatanm yonatanm Awaiting requested review from yonatanm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shlomi-noach @sjmudd