Zstd support #129
Merged
Zstd support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggaspersic
reviewed
Apr 7, 2024
src/main.rs
Outdated
| let reader = io::BufReader::new(gz_decoder); | ||
| Box::new(reader) | ||
| } | ||
| "zst" => { |
There was a problem hiding this comment.
We should add tests when adding a new input/output format
There was a problem hiding this comment.
Github knows you didn't add tests, now that you did the build passes :)
There was a problem hiding this comment.
Unfortunately no, build issue was most likely due to stack/runner conflict, put that on todos
ggaspersic
approved these changes
Apr 8, 2024
bbenshalom
requested changes
Apr 8, 2024
bbenshalom
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
.zst, it appears this works at least as fast also.