Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample builder pattern for GSA Params struct #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Sample builder pattern for GSA Params struct #11

wants to merge 4 commits into from

Conversation

out-somniac
Copy link
Owner

@out-somniac out-somniac commented May 22, 2024 •
edited
Loading

Description

This PR contains builder patterns for algorithm parameters. There are some things to consider before merging. Chiefly:

  • The builder pattern would make sense if any of the parameters were optional. Currently the builder pattern has to assume some default values. This seems like a bad decision
  • Making normalization and discance functions default closures seems to be a good idea. Then builder pattern functions would make sense.

@out-somniac out-somniac added the enhancement New feature or request label May 22, 2024
@out-somniac out-somniac self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

Assignees

@out-somniac out-somniac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@out-somniac @integraledelebesgue