Initial Cambrian integration #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikg4
changed the title
oelachqar
reviewed
Oct 8, 2024
src/oumi/models/experimental/cambrian/model/language_model/phi3/modeling_phi3.py
Outdated
Show resolved
Hide resolved
src/oumi/models/experimental/cambrian/model/language_model/cambrian_phi3.py
Show resolved
Hide resolved
src/oumi/models/experimental/cambrian/model/multimodal_encoder/builder.py
Show resolved
Hide resolved
oelachqar
reviewed
Oct 9, 2024
src/oumi/builders/models.py
Outdated
| @@ -19,6 +20,19 @@ | |||
| except ImportError: | |||
| liger_kernel = None | |||
|
|
|||
| _IS_CAMBRIAN_AVAILABLE = False | |||
There was a problem hiding this comment.
Just for my information -- in what cases would the model not be available?
There was a problem hiding this comment.
These imports may fail if one of their transitive imports isn't available. Moved to build_cambrian()
src/oumi/builders/models.py
Outdated
| @@ -19,6 +20,19 @@ | |||
| except ImportError: | |||
| liger_kernel = None | |||
|
|
|||
| _IS_CAMBRIAN_AVAILABLE = False | |||
| try: | |||
| from oumi.models.experimental.cambrian.mm_utils import ( | |||
There was a problem hiding this comment.
To avoid importing those paths unless they are needed, we could:
a. Use importlib.findspec to test if available
b. Do the imports inside the build_cambrian_function.
Otherwise there is a risk that by importing these in the general case we might get errors because of missing dependencies used only by Cambrian
There was a problem hiding this comment.
moved to build_cambrian() with find_spec()
oelachqar
reviewed
Oct 9, 2024
src/oumi/models/experimental/cambrian/model/language_model/phi3/configuration_phi3.py
Outdated
Show resolved
Hide resolved
oelachqar
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trainandservefor now.oumipackage hierarchyoumiloggerBased on https://github.com/cambrian-mllm/cambrian/tree/78b97086cd96d84e62f45c7cee1b87386615a9a4
This is an initial import. It allows loading of pre-trained Cambrian models (including vision towers) with weights published on HF :
nyu-visionx/cambrian-phi3-3bnyu-visionx/cambrian-8bnyu-visionx/cambrian-13bnyu-visionx/cambrian-34bMore work is needed to enable tuning, and inference.
Towards OPE-374, OPE-377