Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Evaluations] Custom evals: Adding support for eval_kwargs #1557

Merged
merged 3 commits into from
Mar 20, 2025
Merged

[Evaluations] Custom evals: Adding support for eval_kwargs #1557

merged 3 commits into from
Mar 20, 2025

Conversation

kaisopos
Copy link
Contributor

@kaisopos kaisopos commented Mar 19, 2025 •
edited
Loading

Description

Custom evals: Adding support for eval_kwargs

Related issues

Towards OPE-1097

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@kaisopos kaisopos requested review from nikg4 and taenin March 19, 2025 19:01
wizeng23
wizeng23 reviewed Mar 20, 2025
View reviewed changes
tests/unit/core/evaluation/test_evaluator.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a test that checks for the successful merging of kwargs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_evaluate_custom_task does this (after the update).
It merges optional_param_1 and optional_param_2

@kaisopos kaisopos merged commit e9ec359 into main Mar 20, 2025
2 checks passed
@kaisopos kaisopos deleted the kostas/evaluation_custom_evals_eval_kwargs branch March 20, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeng23 wizeng23 wizeng23 approved these changes

@nikg4 nikg4 Awaiting requested review from nikg4

@taenin taenin Awaiting requested review from taenin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaisopos @wizeng23