Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc no-op code cleanups #1553

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Misc no-op code cleanups #1553

merged 2 commits into from
Mar 18, 2025
+40 −59

Conversation

nikg4
Copy link
Collaborator

@nikg4 nikg4 commented Mar 18, 2025 •
edited
Loading

Description

-- Reduce code duplication in vision_language_conversation_feature_generator.py
-- Remove noisy type aliases in conversation.py

Related issues

Towards OPE-991

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@nikg4 nikg4 requested review from optas and taenin March 18, 2025 18:24
@nikg4 nikg4 marked this pull request as ready for review March 18, 2025 18:30
@nikg4 nikg4 changed the title [WIP] Misc no-op code cleanups Misc no-op code cleanups Mar 18, 2025
@nikg4 nikg4 merged commit 32fd6e1 into main Mar 18, 2025
2 checks passed
@nikg4 nikg4 deleted the nikg4/mm-cleanup-v2 branch March 18, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optas optas optas approved these changes

@taenin taenin Awaiting requested review from taenin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikg4 @optas