Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyright breakage when vllm and llama_cpp are not installed #1240

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

taenin
Copy link
Collaborator

@taenin taenin commented Jan 26, 2025

Description

Fixes broken precommits.

Currently they are broken when vllm and llama_cpp are not installed:

check for added large files..............................................Passed
check python ast.........................................................Passed
check for case conflicts.................................................Passed
check docstring is first.................................................Passed
check that executables have shebangs.................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
check that scripts with shebangs are executable..........................Passed
check toml...........................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
debug statements (python)................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
fix utf-8 byte order marker..............................................Passed
mixed line ending........................................................Passed
python tests naming......................................................Passed
don't commit to branch...................................................Passed
trim trailing whitespace.................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Passed
pyright..................................................................Failed
- hook id: pyright
- exit code: 1

/Users/matthewpersons/Repos/oumi/tests/unit/inference/test_inference_engine_init.py
  /Users/matthewpersons/Repos/oumi/tests/unit/inference/test_inference_engine_init.py:33:12 - error: Import "vllm" could not be resolved (reportMissingImports)

Related issues

Fixes N/A

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@taenin taenin marked this pull request as ready for review January 26, 2025 17:39
@taenin taenin requested a review from oelachqar January 26, 2025 17:39
@taenin taenin merged commit 2527a76 into main Jan 26, 2025
2 checks passed
@taenin taenin deleted the taenin/fix_import branch January 26, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants