[Tiny] renaming a field name (init_lora_weights
)
#1236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the PEFT parameter
init_lora_weights
tolora_init_weights
to be name-wise more aligned with the rest of Oumi PEFT parameters.init_lora_weights
is how HF names this.@wizeng23 please note that the file you added adapter_config still lists it as
init_lora_weights
. I think that is OK since that seems to be a file testing HF and not Oumi directly (e.g., it also contains fields like rslora, use_dora etc.)Related issues
Fixes # (issue)
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staff
is required.