Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiny] renaming a field name (init_lora_weights) #1236

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

optas
Copy link
Contributor

@optas optas commented Jan 25, 2025

Description

Renames the PEFT parameter init_lora_weights to lora_init_weights to be name-wise more aligned with the rest of Oumi PEFT parameters. init_lora_weights is how HF names this.

@wizeng23 please note that the file you added adapter_config still lists it as init_lora_weights. I think that is OK since that seems to be a file testing HF and not Oumi directly (e.g., it also contains fields like rslora, use_dora etc.)

Related issues

Fixes # (issue)

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@optas optas requested a review from wizeng23 January 25, 2025 02:22
@optas optas self-assigned this Jan 25, 2025
@optas optas requested a review from oelachqar January 25, 2025 02:23
@oelachqar oelachqar merged commit 76e000c into main Jan 26, 2025
3 checks passed
@oelachqar oelachqar deleted the optas/tiny_change_field_name branch January 26, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants