Skip to content

Refactor/simplify logger a bit #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vrmiguel merged 3 commits into from
Nov 12, 2025
Merged

Refactor/simplify logger a bit #888

vrmiguel merged 3 commits into from
Nov 12, 2025

Conversation

@vrmiguel
Copy link
Member

@vrmiguel vrmiguel commented Nov 12, 2025 •
edited
Loading

  1. Instead of keeping a Vec<String> and then "flushing" it, seems like we can just use a regular BufWriter instead
  2. The above allows us to not need .to_formatted_message anymore. It can just become a Display impl

@vrmiguel vrmiguel merged commit e9a60e0 into main Nov 12, 2025
16 checks passed
@vrmiguel vrmiguel deleted the logger-refac branch November 12, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vrmiguel