AO3-5657 Reassign tag set nominations when pseud is deleted - #5926
Open
pmonfort wants to merge 3 commits into
Open
AO3-5657 Reassign tag set nominations when pseud is deleted#5926pmonfort wants to merge 3 commits into
pmonfort wants to merge 3 commits into
Conversation
sarken
requested changes
Aug 19, 2026
| end | ||
|
|
||
| def change_tag_set_nominations | ||
| default_pseud_id = user.default_pseud.id |
Collaborator
There was a problem hiding this comment.
Would user.default_pseud_id work here?
Contributor
Author
There was a problem hiding this comment.
Makes sense, thanks! 👍
| expect(nomination.reload.pseud_id).to eq(default_pseud.id) | ||
| end | ||
|
|
||
| it "destroys nominations that conflict with the default pseud" do |
Collaborator
There was a problem hiding this comment.
How about arranging this more like
context "when the default pseud has nominations in the same tag set"
it "destroys nominations for that tag set"
it "destroys nominations for that tag set and reassigns nominations in other tags set"
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-5657
Purpose
When a user deletes a pseud, tag set nominations associated with that pseud are left orphaned in the database. The owned_by scope uses an inner join through the pseud, so these orphaned nominations become invisible to the user.
This PR adds tag set nomination reassignment to Pseud#replace_me_with_default, following the same pattern used for comments, gifts, challenge signups, and collection participants. If the default pseud already has a nomination for the same tag set, the conflicting nomination from the deleted pseud is destroyed (along with its associated tag nominations via dependent: :destroy). Otherwise, the nomination is reassigned to the default pseud.
Testing Instructions
Credit
Pablo Monfort (he/him)