Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

Conversation

daochen666
Copy link
Contributor

@daochen666 daochen666 commented Dec 14, 2022

What

Fixing agent bugs:

  1. get_target_table_info should use logical db instead of main db
  2. _add_logical_db_columns did not handle the result correctly3.
  3. logical db connections do not close

Adding new feature to accept postgres DB list from existing PostgresDBName parameter in Cloudformation.

Background

Multi-DB support

Test Plan

Will add tests later.

@daochen666 daochen666 force-pushed the fix_agent_issue_multi_db branch from 0d0fc68 to 6a68e1a Compare December 14, 2022 04:45
@daochen666 daochen666 merged commit 5d26491 into main Dec 14, 2022
@daochen666 daochen666 deleted the fix_agent_issue_multi_db branch December 14, 2022 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants