Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #78 - Fix missing pod owner info #79

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

amit7itz
Copy link
Contributor

@amit7itz amit7itz commented Mar 1, 2023

As reported in issue #78, a bug caused the PodOwnerKind to return empty. The bug happened on services&intents discovered by the socket scan mechanism, due to a missing check of the pod owner.
This PR fixes this issue and adds more checks to the tests to ensure it doesn't happen again.

Closes #78

@amit7itz amit7itz requested a review from orishoshan March 1, 2023 10:38
@amit7itz amit7itz merged commit 69c6c46 into main Mar 1, 2023
@amit7itz amit7itz deleted the amit7itz/fix_missing_pod_owner_info branch March 1, 2023 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query result podOwnerKind is null
2 participants