Skip to content

Improve AWS IAM integration debug logging to improve diagnostics for role creation #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amitlicht merged 2 commits into from
Jan 21, 2025
Merged

Improve AWS IAM integration debug logging to improve diagnostics for role creation #177

amitlicht merged 2 commits into from
Jan 21, 2025

Conversation

@amitlicht
Copy link
Contributor

@amitlicht amitlicht commented Jan 20, 2025

Description

  • Improve AWS IAM integration debug logging to ease troubleshooting around unexpected role creation: add debug- or info-level logging around IAM-related updates of pods and service accounts
  • Remove redundant labeling of service account on last pod terminating in AWS IAM integration, which is no longer used and is just a cause for potential conflicts.

References

#171

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@amitlicht amitlicht requested a review from omris94 January 21, 2025 08:44
@orishoshan orishoshan changed the title Improve AWS IAM integration debug logging to ease troubleshooting around unexpected role creation Improve AWS IAM integration debug logging to improve diagnostics for role creation Jan 21, 2025
@amitlicht amitlicht merged commit b82cdef into main Jan 21, 2025
12 checks passed
@amitlicht amitlicht deleted the amitlicht/troubleshoot_iam_role_override branch January 21, 2025 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@omris94 omris94 omris94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amitlicht @omris94