Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vortex tamer achievement logic #4832

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

omarcopires
Copy link
Contributor

@omarcopires omarcopires commented Nov 11, 2024

Pull Request Prelude

Changes Proposed

This pull request simplifies the logic for the "Vortex Tamer" achievement progression. Previously, the code used a storage to track progress and check if the player should receive the achievement. The new implementation uses the addAchievementProgress function to directly increment the achievement's progress.

@EPuncker EPuncker merged commit 6982d66 into otland:master Nov 12, 2024
5 checks passed
@omarcopires omarcopires deleted the fix-vortex-tamer branch November 12, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants