Fix TestGatheringTimeout test for dns_query plugin (influxdata#4842)

otherpirate · Mar 15, 2019 · f3ee796 · f3ee796
1 parent f3e60d4
commit f3ee796
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/plugins/inputs/dns_query/dns_query_test.go b/plugins/inputs/dns_query/dns_query_test.go
@@ -117,21 +117,17 @@ func TestGatheringTimeout(t *testing.T) {
 	var acc testutil.Accumulator
 	dnsConfig.Port = 60054
 	dnsConfig.Timeout = 1
-	var err error
 
 	channel := make(chan error, 1)
 	go func() {
 		channel <- acc.GatherError(dnsConfig.Gather)
 	}()
 	select {
-	case res := <-channel:
-		err = res
+	case err := <-channel:
+		assert.NoError(t, err)
 	case <-time.After(time.Second * 2):
-		err = nil
+		assert.Fail(t, "DNS query did not timeout")
 	}
-
-	assert.Error(t, err)
-	assert.Contains(t, err.Error(), "i/o timeout")
 }
 
 func TestSettingDefaultValues(t *testing.T) {