Improve error handling in prometheus output (influxdata#5512)

otherpirate · Mar 1, 2019 · 30fcaf0 · 30fcaf0
1 parent 9bd48d4
commit 30fcaf0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/plugins/outputs/prometheus_client/prometheus_client.go b/plugins/outputs/prometheus_client/prometheus_client.go
@@ -176,7 +176,10 @@ func (p *PrometheusClient) Connect() error {
 		}
 	}
 
-	registry.Register(p)
+	err := registry.Register(p)
+	if err != nil {
+		return err
+	}
 
 	if p.Listen == "" {
 		p.Listen = "localhost:9273"
@@ -301,6 +304,7 @@ func (p *PrometheusClient) Collect(ch chan<- prometheus.Metric) {
 				log.Printf("E! Error creating prometheus metric, "+
 					"key: %s, labels: %v,\nerr: %s\n",
 					name, labels, err.Error())
+				continue
 			}
 
 			if p.ExportTimestamp {