Skip to content

Conversation

@othercodes
Copy link
Owner

- Collection::typeOf renamed to Collection::valueType.
- Added Collection::keyType.
- Added invariant methods to check key types.
- Now the Aggregate interface has publishDomainEvent() method.
- Small improvements in Event class.
- Now HasDomainEvents traits has new implementation of publishDomainEvents() method.
- Added new isBound() method to HasServiceBus trait.
- HasDomainEventTest updated.
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #18 (00b21ac) into main (3e97fe4) will increase coverage by 0.40%.
The diff coverage is 74.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #18      +/-   ##
============================================
+ Coverage     82.81%   83.21%   +0.40%     
- Complexity      117      137      +20     
============================================
  Files            20       21       +1     
  Lines           256      292      +36     
============================================
+ Hits            212      243      +31     
- Misses           44       49       +5     
Flag Coverage Δ Complexity Δ
unittests 83.21% <74.07%> (?) 0.00 <28.00> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Domain/Traits/HasServiceBus.php 0.00% <0.00%> (ø) 5.00 <1.00> (+1.00)
src/Domain/ValueObjects/EnumValue.php 0.00% <0.00%> (ø) 8.00 <2.00> (+1.00)
src/Domain/ValueObjects/UUIDValue.php 84.61% <33.33%> (-15.39%) 7.00 <3.00> (+1.00) ⬇️
src/Domain/Bus/Event.php 50.00% <50.00%> (-16.67%) 2.00 <1.00> (ø)
src/Domain/Collection.php 100.00% <100.00%> (ø) 17.00 <17.00> (?)
src/Domain/Criteria/Filter.php 100.00% <100.00%> (ø) 9.00 <3.00> (ø)
src/Domain/Traits/HasDomainEvents.php 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
src/Domain/Traits/HasInvariants.php 100.00% <0.00%> (+4.16%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f065a66...00b21ac. Read the comment docs.

@othercodes othercodes merged commit b25cb24 into main Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants