Skip to content

unidiff header vs git diff header #53

Closed
Closed
unidiff header vs git diff header#53
Labels
stale

Description

@alexec
alexec
opened on Jul 11, 2019

You can't use unidiff AFAIK. You must use git diff

diff --git a/test/fixture/test/ci.go b/test/fixture/test/ci.go
index 6829b8a2..4c565f1b 100644
--- a/test/fixture/test/ci.go
+++ b/test/fixture/test/ci.go
[CHANGES GO HERE]

unidiff format:

--- lao	2002-02-21 23:30:39.942229878 -0800
+++ tzu	2002-02-21 23:30:50.442260588 -0800
[CHANGES GO HERE]

Activity

  1. otakustay commented on Jul 12, 2019

    @otakustay
    otakustay
    on Jul 12, 2019
    Owner

    Yes currently we have only a git diff parser implemented. I'm not familiar to implement a parser so it is quite not possible to implement a unidiff parser according to the Hunk format.

    However you can parse unidiff yourself, Diff component only requires a hunks prop to be rendered.

  2. alexec commented on Jul 12, 2019

    @alexec
    alexec
    on Jul 12, 2019
    Author

    I also noted I would only get file.type = 'modified'. Add and delete are not recognized. Wasn't sure if I was doing this right thing?

  3. alexec commented on Jul 12, 2019

    @alexec
    alexec
    on Jul 12, 2019
    Author

    Do you have an example of parsing unidiff?

  4. otakustay commented on Jul 13, 2019

    @otakustay
    otakustay
    on Jul 13, 2019
    Owner

    Could you provide me a complete unidiff text so I can try it?

  5. alexec commented on Jul 22, 2019

    @alexec
    alexec
    on Jul 22, 2019
    Author

    https://www.gnu.org/software/diffutils/manual/html_node/Unified-Format.html

  6. Neeraj-swarnkar commented on Sep 27, 2019

    @Neeraj-swarnkar
    Neeraj-swarnkar
    on Sep 27, 2019

    Hi,

    This library works fine , but when I am building I am getting this below error.

    Unexpected token: name (t) [./~/unidiff/dist/index.js:1,12782]

    ERROR in graphViews/ComplianceView.a597b349078d83afde42.js from UglifyJs
    Unexpected token: name (t) [./~/unidiff/dist/index.js:1,12782][graphViews/ComplianceView.a597b349078d83afde42.js:27692,12739]

    Can one of you please help ? Thanks.

  7. otakustay
    added 2 commits that reference this issue on Mar 16, 2020

    fix: comptability between git diff and unidiff (#53)

    de9486f

    fix: comptability between git diff and unidiff (#53)

    d7d55f7

  8. stale commented on Jul 28, 2020

    @stale
    stalebot
    on Jul 28, 2020

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  9. stale
    added
    stale
    on Jul 28, 2020
  10. stale
    closed this as completedon Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stale

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions