Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Create sl.json #72

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Create Create sl.json #72

merged 1 commit into from
Feb 5, 2024

Conversation

miropuhek
Copy link
Contributor

Slovenian translations.

Slovenian translations.
@otacke otacke merged commit 86fdff3 into otacke:master Feb 5, 2024
1 check passed
@miropuhek
Copy link
Contributor Author

While translating into Slovene, I noticed what I believe are two typos in the .en.json file. Could you please review the following lines:

  • Line 311: It seems to be identical to line 307, but perhaps it should read, "Will be played when an exercise is closed."
  • Line 588: Is the period here intentional? ". Exercise for @stagelabel""

@otacke
Copy link
Owner

otacke commented Feb 6, 2024

@miropuhek Thanks for being so observant!
The first one was in fact a copy&paste error where I forgot to replace "opened" with "closed".
The second one is in fact correct. It will be concatenated to the stage title that is fetched from the exercise. But I can see how this can be confusing. I'll change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants