Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable no-unused-labels rule #355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

subhanahmed047
Copy link

I noticed that there currently is no way to disable this rule. It would be nice to get this in as I like this library and not having the support to disable this rule is causing me problems.

Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: a6920d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ota-meshi
Copy link
Owner

Can you tell me what problems would arise if no-unused-labels were left enabled?

@ota-meshi ota-meshi added the needs more info More info is needed to complete the issue label Sep 11, 2024
@subhanahmed047
Copy link
Author

Can you tell me what problems would arise if no-unused labels were left enabled?

If you leave it enabled, you'll get a warning on each one of your unused yaml variables. I'm using yaml file as a config and don't reuse the variables.

@ota-meshi
Copy link
Owner

I can't reproduce that. Can you share a repository where we can reproduce that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info More info is needed to complete the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants