Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Apr 2, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
synckit ^0.6.2 || ^0.7.3 || ^0.10.3 -> ^0.6.2 || ^0.7.3 || ^0.11.5 age adoption passing confidence

Release Notes

un-ts/synckit (synckit)

v0.11.5

Compare Source

Patch Changes

v0.11.4

Compare Source

Patch Changes

v0.11.3

Compare Source

Patch Changes

v0.11.2

Compare Source

Patch Changes

v0.11.1

Compare Source

Patch Changes

v0.11.0

Compare Source

Minor Changes
Patch Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: 3140cc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-jsonc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JounQin
Copy link
Collaborator

JounQin commented Apr 2, 2025

synckit@^0.11.1 adds module-sync entry, mocha + ts-node/register seems not working as expected here, I'll try to migrate this repository as ESM primary with commonjs supported at the same time, HDYT? @ota-meshi

module-sync is buggy, I've reverted that change.

@renovate renovate bot force-pushed the renovate/synckit-0.x branch from f8a386c to b864462 Compare May 14, 2025 07:43
@JounQin JounQin changed the title fix(deps): update dependency synckit to ^0.11.0 fix(deps): update dependency synckit to ^0.7.3 || ^0.11.5 May 14, 2025
@renovate
Copy link
Contributor Author

renovate bot commented May 14, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@JounQin JounQin force-pushed the renovate/synckit-0.x branch from 867d10c to ffe2abc Compare May 14, 2025 08:01
@JounQin JounQin changed the title fix(deps): update dependency synckit to ^0.7.3 || ^0.11.5 fix(deps): update dependency synckit to ^0.6.2 || ^0.7.3 || ^0.11.5 May 14, 2025
it("should parse '.json6'", async () => {
const engine = new ESLint({
cwd: TEST_CWD,
// @ts-expect-error -- old ESLint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// in order to update its content execute "npm run update"
export const name = "eslint-plugin-jsonc";
export const version = "2.20.0";
export const name = "eslint-plugin-jsonc" as const;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why there is no issue before.

@JounQin JounQin force-pushed the renovate/synckit-0.x branch from ffe2abc to 1e77176 Compare May 14, 2025 08:07
@JounQin
Copy link
Collaborator

JounQin commented May 14, 2025

@ota-meshi I'm not sure to understand the latest error, it seems plugin = require("../../../../../lib/index") errored which required .ts in eslint.config.js but it's supposed not to, what means npm run build must be executed before npm run test, which also means mocha --require ts-node/register does not work in this case:

1 failing

  1) auto rule with flat config
       should auto rule enable:
     Error while loading rule 'jsonc/auto': Cannot find module '../../../../../dist/index'
Require stack:
- /home/runner/work/eslint-plugin-jsonc/eslint-plugin-jsonc/tests/fixtures/integrations/eslint-plugin/test-auto-rule-with-flat-config01/eslint.config.js
Occurred while linting /home/runner/work/eslint-plugin-jsonc/eslint-plugin-jsonc/tests/fixtures/integrations/eslint-plugin/test-auto-rule-with-flat-config01/src/test.json
  Error: Cannot find module '../../../../../dist/index'
  Require stack:
  - /home/runner/work/eslint-plugin-jsonc/eslint-plugin-jsonc/tests/fixtures/integrations/eslint-plugin/test-auto-rule-with-flat-config01/eslint.config.js
      at Function._resolveFilename (node:internal/modules/cjs/loader:1[40](https://github.com/ota-meshi/eslint-plugin-jsonc/actions/runs/15015560626/job/42192549351?pr=404#step:5:41)1:15)
      at defaultResolveImpl (node:internal/modules/cjs/loader:1057:19)
      at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1062:22)
      at Function._load (node:internal/modules/cjs/loader:1211:37)
      at TracingChannel.traceSync (node:diagnostics_channel:322:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
      at Module.require (node:internal/modules/cjs/loader:1487:12)
      at require (node:internal/modules/helpers:135:16)
      at Object.<anonymous> (tests/fixtures/integrations/eslint-plugin/test-auto-rule-with-flat-config01/eslint.config.js:6:12)
      at Module._compile (node:internal/modules/cjs/loader:1730:14)

@JounQin JounQin force-pushed the renovate/synckit-0.x branch from d352a08 to 3a680c1 Compare May 14, 2025 11:00
@JounQin JounQin force-pushed the renovate/synckit-0.x branch from 3a680c1 to 67181e6 Compare May 14, 2025 11:10
@JounQin
Copy link
Collaborator

JounQin commented May 14, 2025

@ota-meshi Finally this PR is ready now!

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 22b1700 into master May 17, 2025
16 checks passed
@ota-meshi ota-meshi deleted the renovate/synckit-0.x branch May 17, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants