Skip to content

Conversation

@wopss
Copy link

@wopss wopss commented Sep 13, 2025

As described in #466 the plugin is not compatible when using both eslint-plugin-astro and eslint-plugin-jsx-a11y because of the redefinition of jsx-a11y plugin. This PR resolves the issue by renaming the jsx-a11y plugin defined by eslint-plugin-astro to astro/jsx-a11y.

The only concern I have is regarding:

plugins: ["jsx-a11y"],

I believe it should be changed to astro, but since my tests did not show any error, I left it unchanged for now.

I have tested this change in a small repository with both ESLint 9.35.0 and 8.57.1, and everything appears to be working correctly.

Fixes #466.

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2025

⚠️ No Changeset found

Latest commit: 9fd1d22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wopss
Copy link
Author

wopss commented Sep 13, 2025

Regarding the CHANGELOG: I am not sure if this is a breaking change, since this change only updates the defined plugin name to what it should be. As far as I understand ESLint, this redefinition should not affect any written rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin incompatible with eslint-plugin-jsx-a11y

1 participant