feat: pool information being ordered alphabetically and numerically, give full response to user on !pool add success #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
cmyui
reviewed
May 14, 2023
| for (mods, slot), bmap in pool.maps.items(): | ||
| for (mods, slot), bmap in sorted( | ||
| pool.maps.items(), | ||
| key=lambda x: (Mods.to_string(x[0][0]), x[0][1]), |
There was a problem hiding this comment.
i wonder if this would benefit from casefold.. i think we should normalize all mod inputs (maybe we already do) to solve any inconsistencies in casing
cmyui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
i made
!pool infolist alphabetically, then numericallyprevious functionality
new functionality
i made
!pool addlist back whatever mod slot the user selected, instead of just the beatmap and pool nameprevious functionality
Peter Lambert - osu! Tutorial added to HWC22.new functionality
Peter Lambert - osu! Tutorial added to HWC22 as HD1.please ignore the custom embeds and the "FM" entry. those are not included in this pull request.
Related Issues / Projects
Checklist
make lint)