Skip to content

Feature/CO-2036 unit tests #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/db/http/onbase-dao.js
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ const getDocumentContent = async (token, fbLb, documentId) => {
if (err.response && err.response.status === 404) {
logger.error(err.response.data.errors);
return new Error(err.response.data.detail);
} if (err.response && (err.response.status !== 200 || err.response.status !== 206)) {
} if (err.response && !_.includes([200, 206], err.response.status)) {
logger.error(err.response.data.errors);
throw new Error(err.response.data.detail);
}
Expand Down
20 changes: 20 additions & 0 deletions src/tests/unit/documents-serializer.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import chai from 'chai';
import proxyquire from 'proxyquire';

import { fakeDocument } from './mock-data';
import { testMultipleResources, createConfigStub, runSerializerSuite } from './test-helpers';

chai.should();

describe('Test documents-serializer', () => {
const configStub = createConfigStub();
const { serializeDocuments, serializeDocument } = proxyquire('serializers/documents-serializer', {});
configStub.restore();

it('serializeDocuments should properly serialize multiple documents in JSON API format', () => {
const result = serializeDocuments([fakeDocument, fakeDocument], '');
return testMultipleResources(result);
});

runSerializerSuite('serializeDocument', 'a single document', serializeDocument);
});
14 changes: 14 additions & 0 deletions src/tests/unit/keywords-serializer.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import chai from 'chai';
import proxyquire from 'proxyquire';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A blank line is also needed here.


import { createConfigStub, runSerializerSuite } from './test-helpers';

chai.should();

describe('Test keywords-serializer', () => {
const configStub = createConfigStub();
const { serializeKeywords } = proxyquire('serializers/keywords-serializer', {});
configStub.restore();

runSerializerSuite('serializeKeywords', 'keywords collection', serializeKeywords);
});
57 changes: 56 additions & 1 deletion src/tests/unit/mock-data.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,59 @@
const fakeOsuId = '999999999';
const fakeBaseUrl = '/v2';
const fakeDocument = { typeId: 'fake id' };

export { fakeOsuId, fakeBaseUrl };
const docType1 = {
id: '24680',
name: 'TestDocType',
typeId: '924680',
};
const fakeData = {
data: {
access_token: 'fake token',
keywordGuid: 'fake guid',
keywordCollection: 'fake keyword collection',
id: 'fake id',
items: [docType1],
},
};

const keyword1 = {
name: 'Keyword1',
typeId: '924680',
keywordTypeId: '924680',
};
const keyword2 = {
name: 'Keyword2',
typeId: '9123456',
keywordTypeId: '9123456',
};
const keywordType1 = {
id: '924680',
name: 'KeywordType1',
};
const keywordType2 = {
id: '9123456',
name: 'KeywordType2',
};
const fakeKeywordsTypesData = {
data: {
access_token: 'fake token',
keywordGuid: 'fake guid',
keywordCollection: 'fake keyword collection',
id: 'fake id',
items: [keywordType1, keywordType2],
},
};

export {
fakeOsuId,
fakeBaseUrl,
fakeDocument,
docType1,
fakeData,
keyword1,
keyword2,
keywordType1,
keywordType2,
fakeKeywordsTypesData,
};
Loading