-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/CO-2036 unit tests #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4369ee6
Initial checkin unit test
fernamig 90634af
Initial check-in of unit tests
fernamig 8d2494f
merging v2 changes
fernamig 86d8734
Updating unit tests based on code review comments.
fernamig e352eb7
Adding code review comments.
fernamig 3b6c292
Adding updated for code review comments.
fernamig 7b5ef22
Adding changes from code review comments.
fernamig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import chai from 'chai'; | ||
import proxyquire from 'proxyquire'; | ||
|
||
import { fakeDocument } from './mock-data'; | ||
import { testMultipleResources, createConfigStub, runSerializerSuite } from './test-helpers'; | ||
|
||
chai.should(); | ||
|
||
describe('Test documents-serializer', () => { | ||
const configStub = createConfigStub(); | ||
const { serializeDocuments, serializeDocument } = proxyquire('serializers/documents-serializer', {}); | ||
configStub.restore(); | ||
|
||
it('serializeDocuments should properly serialize multiple documents in JSON API format', () => { | ||
const result = serializeDocuments([fakeDocument, fakeDocument], ''); | ||
return testMultipleResources(result); | ||
}); | ||
|
||
runSerializerSuite('serializeDocument', 'a single document', serializeDocument); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import chai from 'chai'; | ||
import proxyquire from 'proxyquire'; | ||
|
||
import { createConfigStub, runSerializerSuite } from './test-helpers'; | ||
|
||
chai.should(); | ||
|
||
describe('Test keywords-serializer', () => { | ||
const configStub = createConfigStub(); | ||
const { serializeKeywords } = proxyquire('serializers/keywords-serializer', {}); | ||
configStub.restore(); | ||
|
||
runSerializerSuite('serializeKeywords', 'keywords collection', serializeKeywords); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,59 @@ | ||
const fakeOsuId = '999999999'; | ||
const fakeBaseUrl = '/v2'; | ||
const fakeDocument = { typeId: 'fake id' }; | ||
|
||
export { fakeOsuId, fakeBaseUrl }; | ||
const docType1 = { | ||
id: '24680', | ||
name: 'TestDocType', | ||
typeId: '924680', | ||
}; | ||
const fakeData = { | ||
data: { | ||
access_token: 'fake token', | ||
keywordGuid: 'fake guid', | ||
keywordCollection: 'fake keyword collection', | ||
id: 'fake id', | ||
items: [docType1], | ||
}, | ||
}; | ||
|
||
const keyword1 = { | ||
name: 'Keyword1', | ||
typeId: '924680', | ||
keywordTypeId: '924680', | ||
}; | ||
const keyword2 = { | ||
name: 'Keyword2', | ||
typeId: '9123456', | ||
keywordTypeId: '9123456', | ||
}; | ||
const keywordType1 = { | ||
id: '924680', | ||
name: 'KeywordType1', | ||
}; | ||
const keywordType2 = { | ||
id: '9123456', | ||
name: 'KeywordType2', | ||
}; | ||
const fakeKeywordsTypesData = { | ||
data: { | ||
access_token: 'fake token', | ||
keywordGuid: 'fake guid', | ||
keywordCollection: 'fake keyword collection', | ||
id: 'fake id', | ||
items: [keywordType1, keywordType2], | ||
}, | ||
}; | ||
|
||
export { | ||
fakeOsuId, | ||
fakeBaseUrl, | ||
fakeDocument, | ||
docType1, | ||
fakeData, | ||
keyword1, | ||
keyword2, | ||
keywordType1, | ||
keywordType2, | ||
fakeKeywordsTypesData, | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A blank line is also needed here.