Merge pull request #108 from osu-mist/feature/CO-2036-unit-tests

Feature/CO-2036 unit tests

Author: fernamig

src/db/http/onbase-dao.js

@@ -547,7 +547,7 @@ const getDocumentContent = async (token, fbLb, documentId) => {
     if (err.response && err.response.status === 404) {
       logger.error(err.response.data.errors);
       return new Error(err.response.data.detail);
-    } if (err.response && (err.response.status !== 200 || err.response.status !== 206)) {
+    } if (err.response && !_.includes([200, 206], err.response.status)) {
       logger.error(err.response.data.errors);
       throw new Error(err.response.data.detail);
     }

src/tests/unit/documents-serializer.test.js

@@ -0,0 +1,20 @@
+import chai from 'chai';
+import proxyquire from 'proxyquire';
+
+import { fakeDocument } from './mock-data';
+import { testMultipleResources, createConfigStub, runSerializerSuite } from './test-helpers';
+
+chai.should();
+
+describe('Test documents-serializer', () => {
+  const configStub = createConfigStub();
+  const { serializeDocuments, serializeDocument } = proxyquire('serializers/documents-serializer', {});
+  configStub.restore();
+
+  it('serializeDocuments should properly serialize multiple documents in JSON API format', () => {
+    const result = serializeDocuments([fakeDocument, fakeDocument], '');
+    return testMultipleResources(result);
+  });
+
+  runSerializerSuite('serializeDocument', 'a single document', serializeDocument);
+});

src/tests/unit/keywords-serializer.test.js

@@ -0,0 +1,14 @@
+import chai from 'chai';
+import proxyquire from 'proxyquire';
+
+import { createConfigStub, runSerializerSuite } from './test-helpers';
+
+chai.should();
+
+describe('Test keywords-serializer', () => {
+  const configStub = createConfigStub();
+  const { serializeKeywords } = proxyquire('serializers/keywords-serializer', {});
+  configStub.restore();
+
+  runSerializerSuite('serializeKeywords', 'keywords collection', serializeKeywords);
+});

src/tests/unit/mock-data.js

@@ -1,4 +1,59 @@
 const fakeOsuId = '999999999';
 const fakeBaseUrl = '/v2';
+const fakeDocument = { typeId: 'fake id' };
 
-export { fakeOsuId, fakeBaseUrl };
+const docType1 = {
+  id: '24680',
+  name: 'TestDocType',
+  typeId: '924680',
+};
+const fakeData = {
+  data: {
+    access_token: 'fake token',
+    keywordGuid: 'fake guid',
+    keywordCollection: 'fake keyword collection',
+    id: 'fake id',
+    items: [docType1],
+  },
+};
+
+const keyword1 = {
+  name: 'Keyword1',
+  typeId: '924680',
+  keywordTypeId: '924680',
+};
+const keyword2 = {
+  name: 'Keyword2',
+  typeId: '9123456',
+  keywordTypeId: '9123456',
+};
+const keywordType1 = {
+  id: '924680',
+  name: 'KeywordType1',
+};
+const keywordType2 = {
+  id: '9123456',
+  name: 'KeywordType2',
+};
+const fakeKeywordsTypesData = {
+  data: {
+    access_token: 'fake token',
+    keywordGuid: 'fake guid',
+    keywordCollection: 'fake keyword collection',
+    id: 'fake id',
+    items: [keywordType1, keywordType2],
+  },
+};
+
+export {
+  fakeOsuId,
+  fakeBaseUrl,
+  fakeDocument,
+  docType1,
+  fakeData,
+  keyword1,
+  keyword2,
+  keywordType1,
+  keywordType2,
+  fakeKeywordsTypesData,
+};