Adding changes from code review comments.

Author: fernamig

src/tests/unit/mock-data.js

@@ -3,57 +3,57 @@ const fakeBaseUrl = '/v2';
 const fakeDocument = { typeId: 'fake id' };
 
 const docType1 = {
-    id: '24680',
-    name: 'TestDocType',
-    typeId: '924680',
+  id: '24680',
+  name: 'TestDocType',
+  typeId: '924680',
 };
 const fakeData = {
-    data: {
-        access_token: 'fake token',
-        keywordGuid: 'fake guid',
-        keywordCollection: 'fake keyword collection',
-        id: 'fake id',
-        items: [docType1],
-    },
-};
-  
+  data: {
+    access_token: 'fake token',
+    keywordGuid: 'fake guid',
+    keywordCollection: 'fake keyword collection',
+    id: 'fake id',
+    items: [docType1],
+  },
+};
+
 const keyword1 = {
-    name: 'Keyword1',
-    typeId: '924680',
-    keywordTypeId: '924680',
+  name: 'Keyword1',
+  typeId: '924680',
+  keywordTypeId: '924680',
 };
 const keyword2 = {
-    name: 'Keyword2',
-    typeId: '9123456',
-    keywordTypeId: '9123456',
+  name: 'Keyword2',
+  typeId: '9123456',
+  keywordTypeId: '9123456',
 };
 const keywordType1 = {
-    id: '924680',
-    name: 'KeywordType1',
+  id: '924680',
+  name: 'KeywordType1',
 };
 const keywordType2 = {
-    id: '9123456',
-    name: 'KeywordType2',
+  id: '9123456',
+  name: 'KeywordType2',
 };
 const fakeKeywordsTypesData = {
-    data: {
-        access_token: 'fake token',
-        keywordGuid: 'fake guid',
-        keywordCollection: 'fake keyword collection',
-        id: 'fake id',
-        items: [keywordType1, keywordType2],
-    },
+  data: {
+    access_token: 'fake token',
+    keywordGuid: 'fake guid',
+    keywordCollection: 'fake keyword collection',
+    id: 'fake id',
+    items: [keywordType1, keywordType2],
+  },
 };
 
 export {
-    fakeOsuId,
-    fakeBaseUrl,
-    fakeDocument,
-    docType1,
-    fakeData,
-    keyword1,
-    keyword2,
-    keywordType1,
-    keywordType2,
-    fakeKeywordsTypesData,
+  fakeOsuId,
+  fakeBaseUrl,
+  fakeDocument,
+  docType1,
+  fakeData,
+  keyword1,
+  keyword2,
+  keywordType1,
+  keywordType2,
+  fakeKeywordsTypesData,
 };

src/tests/unit/onbase-dao.test.js

@@ -11,7 +11,6 @@ import {
   fakeData,
   keyword1,
   keyword2,
-  keywordType1,
   keywordType2,
   fakeKeywordsTypesData,
 } from './mock-data';

src/tests/unit/test-helpers.js

@@ -4,9 +4,8 @@ import _ from 'lodash';
 import proxyquire from 'proxyquire';
 import sinon from 'sinon';
 
-import { fakeDocument } from './mock-data';
 import { logger } from 'utils/logger';
-import { fakeBaseUrl, fakeOsuId } from './mock-data';
+import { fakeBaseUrl, fakeOsuId, fakeDocument } from './mock-data';
 
 /**
  * Creates sinon stub for oracledb connection