Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Packit integration #2210

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Oct 6, 2020

This is a basic .packit.yaml integration file which will allow us have
continuous builds of OSTree in cosa and upstream CI. If things go well,
we'll likely deploy this in other build tools like rpm-ostree.

Prompted by wanting to get #2155 out to unblock
coreos/rpm-ostree#2170.

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: PackitConfigException('Spec file was not found!').

@jlebon
Copy link
Member Author

jlebon commented Oct 6, 2020

So if I read the Packit docs correctly, I think that's all we actually need.

Edit: to clarify, I don't think Packit will actually start a build for this PR until it gets merged. The config sets the trigger as "new commits on the master branch".

This is a basic `.packit.yaml` integration file which will allow us have
continuous builds of OSTree in cosa and upstream CI. If things go well,
we'll likely deploy this in other build tools like rpm-ostree.

Prompted by wanting to get ostreedev#2155 out to unblock
coreos/rpm-ostree#2170.
@cgwalters
Copy link
Member

Sure, happy to try this though as I said I have a long term concern about "yet another system".
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 84f8de6 into ostreedev:master Oct 7, 2020
jlebon added a commit to jlebon/ostree that referenced this pull request Oct 7, 2020
We don't really carry "Fedora-only" patches in dist-git. So we want to
nuke all the patches which exist there.

Follow-up to ostreedev#2210.
@jlebon jlebon deleted the pr/packit branch April 24, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants