Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new container/store module #99

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Add a new container/store module #99

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7660711
tests: Use --no-bindings for base commit
cgwalters Oct 5, 2021
944cf76
Add a new container/store module
cgwalters Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/tests/it/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ fn generate_test_repo(dir: &Utf8Path) -> Result<Utf8PathBuf> {
indoc! {"
cd {dir}
ostree --repo=repo init --mode=archive
ostree --repo=repo commit -b {testref} --bootable --add-metadata-string=version=42.0 --gpg-homedir={gpghome} --gpg-sign={keyid} \
Copy link
Member

@lucab lucab Oct 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do understand the problem behind this, but I'm a bit less sure about the nuances/ramifications of it.
Are ref-bindings going to be problematic in the general case when we try to unencapsulate/import arbitrary commits built from an existing pipeline we don't control (yocto/endless/etc)?

ostree --repo=repo commit -b {testref} --bootable --no-bindings --add-metadata-string=version=42.0 --gpg-homedir={gpghome} --gpg-sign={keyid} \
--add-detached-metadata-string=my-detached-key=my-detached-value --tree=tar=exampleos.tar.zst
ostree --repo=repo show {testref}
"},
Expand All @@ -79,7 +79,7 @@ fn update_repo(repopath: &Utf8Path) -> Result<()> {
let repopath = repopath.as_str();
let testref = TESTREF;
bash!(
"ostree --repo={repopath} commit -b {testref} --tree=tar={srcpath}",
"ostree --repo={repopath} commit -b {testref} --no-bindings --tree=tar={srcpath}",
testref,
repopath,
srcpath
Expand Down