container: Add --write-commitid-to for image deploy
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now in coreos-assembler we have code that wants to know the exact deploy root, and for that with layered images we need the merge commit ID. First, change the deploy API to return the image state. There's no reason to just throw it away. Add an option to the CLI which writes the commitid to a file.
cgwalters
force-pushed
the
deploy-write-ref
branch
from
7ee5eb8
to
f91a180
Compare
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 4, 2022
This requires ostreedev/ostree-rs-ext#275 When `deploy-via-container: true` is used in combination with the new `rpm-ostree container-encapsulate` from coreos/rpm-ostree#3478 We need to use the ostree-container synthetic merge commit to find the deployment. (Actually, what we want is something more like `ostree admin status --json`, or I guess for now `rpm-ostree status --json` to work offline; but for now this is good too)
jlebon
approved these changes
Apr 4, 2022
jlebon
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Apr 4, 2022
This requires ostreedev/ostree-rs-ext#275 When `deploy-via-container: true` is used in combination with the new `rpm-ostree container-encapsulate` from coreos/rpm-ostree#3478 We need to use the ostree-container synthetic merge commit to find the deployment. (Actually, what we want is something more like `ostree admin status --json`, or I guess for now `rpm-ostree status --json` to work offline; but for now this is good too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in coreos-assembler we have code that wants to know
the exact deploy root, and for that with layered images we need
the merge commit ID.
First, change the deploy API to return the image state. There's
no reason to just throw it away.
Add an option to the CLI which writes the commitid to a file.