Bump to containers-image-proxy 0.3, add proxy config as API and CLI #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy has gone back to a shared borrow with internal locking.
We will need to support basically all options that the proxy does, such as disabling TLS, separate authfile etc. Rather than write a new type, just re-export it. Thread the new options struct through the store and deploy APIs.
We want this for the same reason they exist in skopeo around non-default authfiles, etc. The chain here is pretty amazing: - containers/image internal Go API - skopeo CLI flags - containers/containers-image-proxy Rust API - ostreedev/ostree-rs-ext Rust API - ostreedev/ostree-rs-ext CLI code - rpm-ostree CLI
cgwalters
force-pushed
the
imageproxy-update
branch
from
727493e
to
3873ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to containers-image-proxy 0.3
lib/container: Drop unnecessary
mutfor proxyThe proxy has gone back to a shared borrow with internal locking.
lib: Expose proxy configuration as public API
We will need to support basically all options that the proxy
does, such as disabling TLS, separate authfile etc.
Rather than write a new type, just re-export it.
Thread the new options struct through the store and deploy APIs.
cli: Expose current container proxy opts as CLI flags
We want this for the same reason they exist in skopeo
around non-default authfiles, etc.
The chain here is pretty amazing: