fix faulty specs to be more accurate#10
Open
kivra-kenand wants to merge 1 commit intoostinelli:masterfrom
Open
fix faulty specs to be more accurate#10kivra-kenand wants to merge 1 commit intoostinelli:masterfrom
kivra-kenand wants to merge 1 commit intoostinelli:masterfrom
Conversation
Author
|
@ostinelli I know this repo has not had much action in some time but would it possible to take a look at this anyways? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that equery/2 when doing a
SELECT * FROMquery returns the columns as the second argument and not a count.I've updated all the specs to utilize the
epgsql_cmd_prepared_query:response()spec instead which is more accurate.