Skip to content

Get Coverage > 90% In All Modules #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 12, 2024
Merged

Get Coverage > 90% In All Modules #630

merged 19 commits into from
May 12, 2024

Conversation

reid-spencer
Copy link
Contributor

No description provided.

@reid-spencer reid-spencer linked an issue May 5, 2024 that may be closed by this pull request
Get Each Module > 90% Coverage #628
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9047480155

Details

  • 43 of 52 (82.69%) changed or added relevant lines in 10 files are covered.
  • 84 unchanged lines in 43 files lost coverage.
  • Overall coverage increased (+3.3%) to 74.956%
Changes Missing Coverage Covered Lines Changed/Added Lines %
hugo/src/main/scala/com/ossuminc/riddl/hugo/mermaid/DataFlowDiagram.scala 5 6 83.33%
passes/src/main/scala/com/ossuminc/riddl/passes/symbols/SymbolsOutput.scala 26 27 96.3%
prettify/src/main/scala/com/ossuminc/riddl/prettify/PrettifyPass.scala 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
testkit/src/main/scala/com/ossuminc/riddl/testkit/ValidatingTest.scala 1 24.14%
language/src/main/scala/com/ossuminc/riddl/language/parsing/HandlerParser.scala 1 78.57%
prettify/src/main/scala/com/ossuminc/riddl/prettify/PrettifyState.scala 1 57.58%
hugo/src/main/scala/com/ossuminc/riddl/hugo/writers/EpicWriter.scala 1 61.9%
commands/src/main/scala/com/ossuminc/riddl/commands/RepeatCommand.scala 1 82.89%
hugo/src/main/scala/com/ossuminc/riddl/hugo/themes/ThemeGenerator.scala 1 35.71%
hugo/src/main/scala/com/ossuminc/riddl/hugo/writers/SummariesWriter.scala 1 97.47%
hugo/src/main/scala/com/ossuminc/riddl/hugo/ToDoListPass.scala 1 57.58%
passes/src/main/scala/com/ossuminc/riddl/passes/validate/ValidationPass.scala 1 66.88%
analyses/src/main/scala/com/ossuminc/riddl/analyses/StatsPass.scala 1 90.24%
Totals Coverage Status
Change from base Build 8953074064: 3.3%
Covered Lines: 5522
Relevant Lines: 7367
💛 - Coveralls

Add more coverage
7cfdcf1 
* Test the DataFlowDiagram
* Remove the incomplete D3 code
* Add a "hassOutputOf" method to PassesResult
* Add validation tests for streams
Add more coverage changes
b4d8b9a 
* Removed unused code from Punctuation
* Make TopLevelParser.root public
* Add a test suite for TestParser
Add more coverage changes
b8b6401 
* Run the DiagramsPass and test for sanity
* Add adaptor and repository to everything.riddl
* Deal with the fallout of everything.riddl changes
* Rename userCaseDiagrams -> useCaseDiagrams
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@reid-spencer reid-spencer merged commit b6f616e into main May 12, 2024
@reid-spencer reid-spencer deleted the 628-get-each-module-90-coverage branch May 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Each Module > 90% Coverage
1 participant
@reid-spencer