Fix hevc test failures #4087
Merged
Fix hevc test failures #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzp1984
force-pushed
the
fix/hevc_test_fail
branch
10 times, most recently
from
cca9e35 to
da6a7d7
Compare
suzp1984
force-pushed
the
fix/hevc_test_fail
branch
from
da6a7d7 to
cfda86c
Compare
suzp1984
commented
Jun 14, 2024
| @@ -995,11 +994,14 @@ func TestSlow_SrtPublish_HlsPlay_HEVC_Basic(t *testing.T) { | |||
| defer wg.Done() | |||
| <-svr.ReadyCtx().Done() | |||
|
|
|||
| // wait for ffmpeg | |||
| time.Sleep(3 * time.Second) | |||
|
|
|||
There was a problem hiding this comment.
No need to sleep here, ffmpeg can publish stream immediately after srs ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix two blackbox test:
2 TestSlow_SrtPublish_HlsPlay_HEVC_Basic: fixed by wait 16 seconds before run ffprobe task.
About the 2 case: it seems ridiculous to add 16 seconds delay before run ffprobe task.
I confirmed this is not the SRS source code's problem, check https://github.com/suzp1984/srs/actions/runs/9511600525/job/26218025559
the srs code 6.0.113 was checkout and running actions based on them, still met same problem.